fix(core): Don't let a throwing beforeSendSpan callback escape into user code - #22836
Draft
Lms24 wants to merge 1 commit into
Draft
fix(core): Don't let a throwing beforeSendSpan callback escape into user code#22836Lms24 wants to merge 1 commit into
beforeSendSpan callback escape into user code#22836Lms24 wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
fix/before-send-span-throw
branch
from
July 29, 2026 15:37
2b3d3e2 to
192e001
Compare
… user code Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
fix/before-send-span-throw
branch
from
August 3, 2026 12:58
192e001 to
f1557e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the
beforeSendSpancallback application incaptureSpanin a try/catch, logging the error and sending the span unmodified instead of letting the throw escape.Spans are captured synchronously from the
afterSpanEndhook, so a throwing callback propagates straight out of whatever user code calledspan.end(). That turns a faulty Sentry option into an exception in unrelated application code — a failure mode the SDK should never introduce.This is particularly relevant now that
beforeSendSpanreceivesStreamedSpanJSONby default: a v10 callback that wasn't migrated and reaches intospan.datathrows on the first ended span, which would otherwise break the instrumented app rather than just degrading span processing. Falling back to the unmodified span keeps data flowing and surfaces the problem through a debug-build error log.